git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH/RFC v5 1/1] more cache effective symlink/directory detection

From
KBKjetil Barvik <barvik@broadpark.no>
Date
Jan 11, 2009, 08:26 UTC
Message-ID
<86vdsm8d09.fsf@broadpark.no>
In-Reply-To
<7vljtivfao.fsf@gitster.siamese.dyndns.org>
Junio C Hamano <gitster@pobox.com> writes:
Show 19 quoted lines
> René Scharfe <rene.scharfe@lsrfire.ath.cx> writes:
>
>> Kjetil Barvik schrieb:
>>> - Also introduce a 'void clear_lstat_cache(void)' function, which
>>>   should be used to clean the cache before usage.  If for instance,
>>>   you have changed the types of directories which should be cached,
>>>   the cache could contain a path which was not wanted.
>>
>> Is it possible to make the cache detect these situations automatically
>> by saving track_flags along with the cache contents?  Not having to
>> clear the cache manually would be a major feature.
>
>> Also, it's probably worth to split this patch up again.  First switching
>> to your improved implementation of has_symlink_leading_path(), then
>> introducing has_symlink_or_noent_leading_path() and finally adding
>> LSTAT_FULLPATH and the fourth parameter of lstat_cache() etc. and using
>> this feature in entry.c seems like a nice incremental progression.
>
> Both are reasonable suggestions.  Thanks.
  Ok!  Thanks for comments!  Version 6 will follow shortly!
  -- kjetil
Previous: Junio C Hamano
Message 5 of 5 in “git checkout: optimise away lots of lstat() calls”
  1. 0/1 git checkout: optimise away lots of lstat() callsKjetil Barvik, Jan 9, 2009
  2. 1/1 more cache effective symlink/directory detectionKjetil Barvik, Jan 9, 2009
  3. René ScharfeJan 10, 2009
  4. Junio C HamanoJan 11, 2009
  5. Kjetil BarvikJan 11, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.