Re: [PATCH] Add git-sh-setup::set_editor()

From: David Kastrup <dak@gnu.org>
Date: Jul 19, 2007, 19:26 UTC
Message-ID: <86tzs0yz27.fsf@lola.quinscape.zz>
In-Reply-To: <Pine.LNX.4.64.0707191944560.14781@racer.site>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

Show 20 quoted lines

> On Thu, 19 Jul 2007, Adam Roben wrote:
>
>> This function can be used to set the GIT_EDITOR variable to the user's
>> preferred editor.
>
> Much nicer, thank you.
>
> However,
>
>> -	commit_editor=$(git config core.editor || echo ${VISUAL:-$EDITOR})
>> -	case "$commit_editor,$TERM" in
>> +	case "$GIT_EDITOR,$TERM" in
>>  	,dumb)
>
> This can no longer happen, since ...
>
>> +set_editor() {
>> +    GIT_EDITOR=$(git config core.editor || echo ${VISUAL:-${EDITOR:-vi}})
>> +    export GIT_EDITOR
>> +}

Strictly speaking it can happen when git has an empty string for core.editor configured. Not that the behavior chosen in this case would make any sense, but just for the record...

-- 
David Kastrup