Re: [PATCH] Makefile: turn on USE_ST_TIMESPEC for FreeBSD

From: Kjetil Barvik <barvik@broadpark.no>
Date: Mar 22, 2009, 14:15 UTC
Message-ID: <86skl5d4o2.fsf@broadpark.no>
In-Reply-To: <20090322080847.GA9075@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 6 quoted lines

> Fixes broken compilation on FreeBSD 6.1.
>
> Signed-off-by: Jeff King <peff@peff.net>
> ---
> No idea if older versions support this, or if they just need NO_NSEC
> instead.

  I google'd a litle and found this:

    http://fuse4bsd.creo.hu/localcgi/man-cgi.cgi?lstat+2
    http://www.nabble.com/st_mtimespec-or-st_mtime--td21217981.html

  So, at least FreeBSD 6.2 also seems to need this.  And I suspect that
  OpenBSD and/or NetBSD maybe need a simmilar patch.  Anybody who can
  test this?

  -- kjetil

Show 15 quoted lines

>  Makefile |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index aae3b09..320c897 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -713,6 +713,7 @@ ifeq ($(uname_S),FreeBSD)
>  	BASIC_CFLAGS += -I/usr/local/include
>  	BASIC_LDFLAGS += -L/usr/local/lib
>  	DIR_HAS_BSD_GROUP_SEMANTICS = YesPlease
> +	USE_ST_TIMESPEC = YesPlease
>  	THREADED_DELTA_SEARCH = YesPlease
>  	ifeq ($(shell expr "$(uname_R)" : '4\.'),2)
>  		PTHREAD_LIBS = -pthread