Re: [PATCH] check_updates(): effective removal of cache entries marked CE_REMOVE
Alex Riesen <raa.lkml@gmail.com> writes:
Show 25 quoted lines
> 2009/2/18 Kjetil Barvik <barvik@broadpark.no>:
>> If we can trust the numbers from oprofile in this case, we saved
>> approximately ((7710 - 46) * 20000) / (2 * 1000 * 1000 * 1000) = 0.077
>> seconds CPU time with this fix for this particular test. And notice
>> that now the CPU did only 46 / 15 = 3.1 cycles/instruction.
> ...
>> diff --git a/unpack-trees.c b/unpack-trees.c
>> index e3c3fa1..273b5da 100644
>> --- a/unpack-trees.c
>> +++ b/unpack-trees.c
>> @@ -93,11 +93,9 @@ static int check_updates(struct unpack_trees_options *o)
>> display_progress(progress, ++cnt);
>> if (o->update)
>> unlink_entry(ce);
>> - remove_index_entry_at(&o->result, i);
>> - i--;
>> - continue;
>> }
>> }
>> + remove_marked_cache_entries(&o->result);
>> remove_scheduled_dirs();
>>
>
> What commit is this change based on? It does not apply to any
> of Junio's master, next, or pu...
It was based on 'pu', and not a uptodate one. Sorry about that, I
will update the patch based on master, and include it together with
the 2 'USE_NSEC'-patches, which I posted some few days ago.
-- kjetil