Re: [PATCH] git-svn: Print revision while searching for earliest use of path

From: Deskin Miller <deskinm@umich.edu>
Date: Feb 5, 2009, 13:42 UTC
Message-ID: <86d4c5e00902050542n74b10bfdw5e9249ac23fdc9e7@mail.gmail.com>
In-Reply-To: <86d4c5e00902050540lf8a3adfq18b1fed909d6e68a@mail.gmail.com>

Resending due to temporary insanity with email, sorry Eric.

On Thu, Feb 5, 2009 at 01:42, Eric Wong <normalperson@yhbt.net> wrote:

Show 7 quoted lines

> Deskin Miller <deskinm@umich.edu> wrote:
>> If the current version is
>> felt to be too verbose since it is printing a new line, I'd be up for
>> squelching the output to e.g. every 1000 revisions or so.
>
> This is definitely useful on slow/large repositories.  The current
> output with newlines is fine by me.

Ok.

> Couldn't we avoid the trouble of parsing the inconsistent error
> messages by printing this status message after the get_log() calls
> in gs_fetch_loop_common() ?

I didn't look at get_log closely, because I thought it executed only once. I definitely agree that it would be cleaner if it's possible. Let me look at the code some more and I'll see what I can do, or feel free to post an alternate implementation.

Deskin Miller