Re: [PATCH v3] userdiff: add Elixir to supported userdiff languages

From: Łukasz Niemier <lukasz@niemier.pl>
Date: Nov 8, 2019, 15:42 UTC
Message-ID: <86417D50-2C28-477A-BC49-9097A24A3BF3@niemier.pl>
In-Reply-To: <f85a5c31-52ff-85be-b1e0-f3982fd2a7f2@kdbg.org>

> Please keep the Cc list when you send new patch versions. Also, it is
> customary to send them as replies to the earlier iterations, so that
> they all end up in the same thread.

Sorry, I am still learning how to use git send-email and I thought it would be handled automatically. I need to find how to operate it properly and how to configure it to reply in thread instead of creating new one.

> There are no single- and double-quote anymore. An oversight? Or an error
> in the earlier iteration?

No, I intentionally left them out, as :’foo bar’ is allowed atom, and I didn’t want to complicate everything word regex. Instead I assumed that these are so rare, that it should not be a problem.

Show 5 quoted lines

> The leading optional sign may be problematic. When a patch changes "i+1"
> to "i+2", it would be highlighted as "i{-+1-}{++2+}" instead of as
> "i+{-1-}{+2+}". You could remove the leading optional sign and let it be
> processed as an operator. But we also have an optional sign in the cpp
> pattern as well, and haven't noticed it until now, so…

I copied this pattern from other languages, so I assumed that this is what is expected. It could be fixed, but I think it should be handled in separate patch.

--

Łukasz Niemier lukasz@niemier.pl