Re: [PATCH 0/2] replacing ci/config/allow-ref with a repo variable

From: Phillip Wood <phillip.wood123@gmail.com>
Date: Sep 1, 2023, 13:24 UTC
Message-ID: <8624fc43-ab42-442b-a141-851fc35dd24f@gmail.com>
In-Reply-To: <20230830194919.GA1709446@coredump.intra.peff.net>

Hi Peff

On 30/08/2023 20:49, Jeff King wrote:

> This is a more efficient way to do the same thing that
> ci/config/allow-ref does (which didn't exist back then).

I like the idea of a more efficient way to skip the ci for certain refs. I've got my allow-ref script set up to reject a bunch of refs and run the ci on everything else. It's not clear to me how to replicate that with the setup proposed here. Would it be possible to add a second variable that prevents the ci from being run if it contains ref being pushed?

Best Wishes

Phillip

Show 18 quoted lines

> We should be able to do the same with ci/config/skip-concurrent (and
> just use vars.CI_SKIP_CONCURRENT) throughout the workflow. But I didn't
> test that at all.
> 
> After that, the only useful thing left in the "config" job would be the
> "skip-if-redundant" step. I'm not sure if it will be possible to get the
> same behavior there without spinning up a VM.
> 
>    [1/2]: ci: allow branch selection through "vars"
>    [2/2]: ci: deprecate ci/config/allow-ref script
> 
>   .github/workflows/main.yml | 10 +++++++---
>   ci/config/README           | 14 ++++++++++++++
>   ci/config/allow-ref.sample | 27 ---------------------------
>   3 files changed, 21 insertions(+), 30 deletions(-)
>   create mode 100644 ci/config/README
>   delete mode 100755 ci/config/allow-ref.sample
>