[PATCH] t4062: stop using repetition in regex
- From
René Scharfe <l.s.r@web.de>
- Date
- Aug 8, 2017, 06:53 UTC
- Message-ID
- <861dc875-7300-fe5a-1360-0ed546c8c2bb@web.de>
OpenBSD's regex library has a repetition limit (RE_DUP_MAX) of 255. That's the minimum acceptable value according to POSIX. In t4062 we use 4096 repetitions in the test "-G matches", though, causing it to fail.
Do the same as the test "-S --pickaxe-regex" in the same file and search for a single zero instead. That still suffices to trigger the buffer overrun in older versions (checked with b7d36ffca02^ and --valgrind on Linux), simplifies the test a bit, and avoids exceeding OpenBSD's limit.
Original-patch-by: David Coppa <dcoppa@openbsd.org> Signed-off-by: Rene Scharfe <l.s.r@web.de> --- t/t4062-diff-pickaxe.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t4062-diff-pickaxe.sh b/t/t4062-diff-pickaxe.sh index 7c4903f497..c16e5af6fa 100755 --- a/t/t4062-diff-pickaxe.sh +++ b/t/t4062-diff-pickaxe.sh @@ -15,7 +15,7 @@ test_expect_success setup ' git commit -m "A 4k file" ' test_expect_success '-G matches' ' - git diff --name-only -G "^0{4096}$" HEAD^ >out && + git diff --name-only -G0 HEAD^ >out && test 4096-zeroes.txt = "$(cat out)" '
-- 2.14.0