Re: [PATCH] rebase -m: Fix incorrect short-logs of already applied commits.

From: David Kastrup <dak@gnu.org>
Date: Sep 1, 2007, 09:20 UTC
Message-ID: <85ps12agiz.fsf@lola.goethe.zz>
In-Reply-To: <7vmyw6u5ca.fsf@gitster.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

> I would propose doing the attached patch on top of yours.
> Opinion?
>
> +	git rev-list --pretty=oneline -1 "$cmt" | sed -e 's/^[^ ]* //'

What about

    git-rev-list --pretty=format:%s -1 "$cmt"

It seems pretty pointless to first print with a wrong format, then fix it up afterwards.

Incidentally, the above spews out a full commit line before the entry (meaning this does not work with current git-rev-list). This is arguably wrong: when format: is employed, the user presumably knows perfectly well what he wants printed.

So I guess I vouch for both not using sed as well as what I consider fixing git-rev-list --pretty=format:

-- 
David Kastrup, Kriemhildstr. 15, 44793 Bochum