git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: --exit-code (and --quiet) broken in git-diff?

From
David Kastrup <dak@gnu.org>
Date
Aug 12, 2007, 11:31 UTC
Message-ID
<85643lq99h.fsf@lola.goethe.zz>
In-Reply-To
<24332.88.10.191.55.1186917895.squirrel@secure.wincent.com>
"Wincent Colaiuta" <win@wincent.com> writes:
Show 7 quoted lines
> René Scharfe wrote:
>>
>> git diff passes the output through your pager by default, so you see the
>> exit code of that instead of diff's.  Set PAGER=cat or redirect the
>> output to /dev/null to get rid of it.
>
> Ah, thanks very much René!

I think I would call that a mistake. However, I don't see that fixing it would actually be useful: if a pager gets called, this means that git-diff might die with SIGPIPE (when the user quits the pager), and that in turn has pretty much no meaning. So one really needs to redirect the output, anyway.

-- 
David Kastrup, Kriemhildstr. 15, 44793 Bochum
Previous: Wincent ColaiutaNext: Steven Grimm
Message 4 of 12 in “--exit-code (and --quiet) broken in git-diff?”
  1. Wincent ColaiutaAug 11, 2007
  2. René ScharfeAug 12, 2007
  3. Wincent ColaiutaAug 12, 2007
  4. David KastrupAug 12, 2007
  5. Steven GrimmAug 12, 2007
  6. David KastrupAug 12, 2007
  7. Wincent ColaiutaAug 12, 2007
  8. Steffen ProhaskaAug 12, 2007
  9. diff: don't run pager if user asked for a diff style exit codeRené Scharfe, Aug 12, 2007
  10. Wincent ColaiutaAug 13, 2007
  11. David KastrupAug 13, 2007
  12. Junio C HamanoAug 13, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.