git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/4] merge: add missing word "strategy" to a message

From
Philippe Blain via GitGitGadget <gitgitgadget@gmail.com>
Date
Jul 23, 2021, 12:14 UTC
Message-ID
<85016e679eb77cbb17edc9b6849251893a5e9ec2.1627042470.git.gitgitgadget@gmail.com>
In-Reply-To
<pull.1002.git.1627042470.gitgitgadget@gmail.com>
From: Philippe Blain <levraiphilippeblain@gmail.com>

The variable 'best_strategy' holds the name of the merge strategy that resulted in fewer conflicts, if several strategies were tried. When that's the case but the best strategy was not the first one tried, we inform the user which strategy was the "best" one before recreating the merge and leaving the conflicted files in the tree.

This informational message is missing the word "strategy", so it shows something like:

    Using the recursive to prepare resolving by hand.
Fix that.
Signed-off-by: Philippe Blain <levraiphilippeblain@gmail.com>
---
 builtin/merge.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builtin/merge.c b/builtin/merge.c
index a8a843b1f54..74797b6c7a6 100644
--- a/builtin/merge.c
+++ b/builtin/merge.c
@@ -1715,7 +1715,7 @@ int cmd_merge(int argc, const char **argv, const char *prefix)
 	else {
 		printf(_("Rewinding the tree to pristine...\n"));
 		restore_state(&head_commit->object.oid, &stash);
-		printf(_("Using the %s to prepare resolving by hand.\n"),
+		printf(_("Using the %s strategy to prepare resolving by hand.\n"),
 			best_strategy);
 		try_merge_strategy(best_strategy, common, remoteheads,
 				   head_commit);
-- 
gitgitgadget
Previous: Philippe Blain via GitGitGadgetNext: Felipe Contreras
Message 2 of 11 in “[RFC] merge --autostash: apply autostash in more cases”
  1. 0/4 [RFC] merge --autostash: apply autostash in more casesPhilippe Blain via GitGitGadget, Jul 23, 2021
  2. 1/4 merge: add missing word "strategy" to a messagePhilippe Blain via GitGitGadget, Jul 23, 2021
  3. Felipe ContrerasJul 23, 2021
  4. 3/4 merge: apply autostash if fast-forward failsPhilippe Blain via GitGitGadget, Jul 23, 2021
  5. Felipe ContrerasJul 23, 2021
  6. Junio C HamanoJul 23, 2021
  7. 2/4 Documentation: define 'MERGE_AUTOSTASH'Philippe Blain via GitGitGadget, Jul 23, 2021
  8. Felipe ContrerasJul 23, 2021
  9. 4/4 merge: apply autostash if merge strategy failsPhilippe Blain via GitGitGadget, Jul 23, 2021
  10. Junio C HamanoJul 23, 2021
  11. Felipe ContrerasJul 23, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.