Re: [GSoC PATCH] promisor-remote: fix promisor.quiet to use the correct repository
- From
Tian Yuchen <a3205153416@gmail.com>
- Date
- Apr 8, 2026, 17:53 UTC
- Message-ID
- <84ca1cfa-a8b8-4426-b610-c9bc24843c25@gmail.com>
- In-Reply-To
- <20260406183041.783800-1-vikingtc4@gmail.com>
On 4/7/26 02:30, Trieu Huynh wrote:
I strongly recommend you to run a patch locally before sending it.
not ok 38 - promisor.quiet from submodule repo is honored
Show 24 quoted lines
> +test_expect_success 'promisor.quiet from submodule repo is honored' ' > + rm -f pc-quiet-trace && > + > + # Set promisor.quiet only in the submodule, not the superproject. > + git -C super-work/sub config promisor.quiet true && > + > + # Push a new commit+blob to the server; the blob stays missing in the > + # partial-clone submodule until a lazy fetch is triggered. > + test_commit -C sub-pc-src updated new-file.txt "world" && > + git -C sub-pc-src push "$(pwd)/sub-pc-srv.bare" HEAD:master && > + git -C super-work/sub -c protocol.file.allow=always fetch origin && > + git -C super-work/sub reset --mixed origin/master && > + > + # grep descends into the submodule and triggers a lazy fetch for the > + # missing blob; verify the fetch subprocess carries --quiet. > + GIT_TRACE2_EVENT="$(pwd)/pc-quiet-trace" \ > + git -C super-work grep --cached --recurse-submodules "world" \ > + 2>/dev/null && > + grep negotiationAlgorithm pc-quiet-trace | grep -e --quiet > +' > + > . "$TEST_DIRECTORY"/lib-httpd.sh > start_httpd >
Regards, Yuchen