Re: [PATCH] Make strbuf_cmp inline, constify its arguments and optimize it a bit

From: Florian Weimer <fweimer@bfk.de>
Date: Oct 8, 2007, 08:54 UTC
Message-ID: <82k5py6l6f.fsf@mid.bfk.de>
In-Reply-To: <20071008072312.GA22552@artemis.corp>

* Pierre Habouzit:

Show 6 quoted lines

>> So I think the last line can just be:
>> 
>>    return a->len - b->len;
>
>   Won't work because ->len are size_t and return value is int, so on 64
> bits platform, this has chances to overflow.

Nit: It can overflow on 32-bit, too.

And "int len" in the first line of the function body should be "size_t len".

Moving that to a compare_int/compare_size_t function should help; AFAIK there's no short idiom which does the job.

-- 
Florian Weimer                <fweimer@bfk.de>
BFK edv-consulting GmbH       http://www.bfk.de/
Kriegsstraße 100              tel: +49-721-96201-1
D-76133 Karlsruhe             fax: +49-721-96201-99