Re: [PATCH] gitk: add user-defined custom commands

From: Johannes Sixt <j6t@kdbg.org>
Date: Aug 5, 2026, 06:59 UTC
Message-ID: <82e59e71-5cb0-4a7f-9fc1-e66b367670f0@kdbg.org>
In-Reply-To: <pull.2371.git.git.1785879839766.gitgitgadget@gmail.com>

Am 04.08.26 um 23:43 schrieb Tim Wiederhake via GitGitGadget:

Show 11 quoted lines

> Allow users to define up to three custom commands each for the commit
> list and the diff display area.  Commands are configured in a new
> "Commands" tab in the preferences dialog, with a name and a command
> template per slot.  Non-empty slots appear in the right-click context
> menu of the respective area.
> 
> Command templates support placeholder substitution (commit id, commit
> title, author name, author date, etc.) and are executed via "sh -c"
> to allow for background execution by appending "&", and pipeing.  If
> a command terminates with exit code 42, its output is displayed;
> otherwise only non-zero exit codes are reported.

Thanks, but this commit message is a bit lacking: it does not explain why it is a good idea to have this feature, what purpose it servers. For this reason, it is not possible to tell whether the design is sound and whether the implementation follows the design.

> Signed-off-by: Tim Wiederhake <twied@gmx.net>
> Assisted-by: Claude Opus 4.6

Thank you for being explicit about AI assistance. Note that this code is going to be downstreamed to the Git project. Therefore, their AI rules[*] must be obeyed.

Equally important is that I want to be sure that you have checked and carefully reviewed and understood everything the AI produced. I am not going to look at the code until there is sufficient insurance that you did. (Blatantly put, I don't want to review code produced by someone else with AI.)

[*] https://git-scm.com/docs/SubmittingPatches#ai

-- Hannes