git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCHv2] test-lib: TAP compliance for skipping tests on request

From
Michael J Gruber <git@drmicha.warpmail.net>
Date
Jul 12, 2010, 10:33 UTC
Message-ID
<82aab66bffd86b562c76a13a4666d3cf22a64cca.1278930335.git.git@drmicha.warpmail.net>
In-Reply-To
<AANLkTiml1lQlSBDGgUg9scsvsaffDT2n405USmsSIm1n@mail.gmail.com>
Make the output TAP compliant for tests skipped on request (GIT_SKIP_TESTS).
Signed-off-by: Michael J Gruber <git@drmicha.warpmail.net>
---
v2 has a typo fix in the commit message and the spelling of "skip"
as suggested by AAB.

I think I've read it differently in the RFC, but then I was also confused about the "#" in the RFC, and following the "reference" implementation (as per AAB) should be the best approach.

 t/test-lib.sh |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/t/test-lib.sh b/t/test-lib.sh
index bc06564..db8371c 100644
--- a/t/test-lib.sh
+++ b/t/test-lib.sh
@@ -396,7 +396,7 @@ test_skip () {
 	case "$to_skip" in
 	t)
 		say_color skip >&3 "skipping test: $@"
-		say_color skip "ok $test_count: # skip $1"
+		say_color skip "ok $test_count # skip $1"
 		: true
 		;;
 	*)
@@ -833,7 +833,7 @@ do
 	case "$this_test" in
 	$skp)
 		say_color skip >&3 "skipping test $this_test altogether"
-		say_color skip "skip all tests in $this_test"
+		skip_all="skip all tests in $this_test"
 		test_done
 	esac
 done
-- 
1.7.2.rc1.212.g850a
Previous: Ævar Arnfjörð BjarmasonNext: Ævar Arnfjörð Bjarmason
Message 3 of 5 in “test-lib: TAP compliance for skipping tests on request”
  1. test-lib: TAP compliance for skipping tests on requestMichael J Gruber, Jul 9, 2010
  2. Ævar Arnfjörð BjarmasonJul 9, 2010
  3. [PATCHv2] test-lib: TAP compliance for skipping tests on requestMichael J Gruber, Jul 12, 2010
  4. Ævar Arnfjörð BjarmasonJul 12, 2010
  5. Junio C HamanoJul 12, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.