Re: [JGIT PATCH 2/2] Make Repository.isValidRefName compatible with Git 1.6.3

From: Alex Riesen <raa.lkml@gmail.com>
Date: May 8, 2009, 07:24 UTC
Message-ID: <81b0412b0905080024r211864bfhe7f70acabe0880c6@mail.gmail.com>
In-Reply-To: <20090508004741.GU30527@spearce.org>

2009/5/8 Shawn O. Pearce <spearce@spearce.org>:

Show 14 quoted lines

> --- a/lockfile.c
> +++ b/lockfile.c
> @@ -129,11 +129,11 @@ static int lock_file(struct lock_file *lk, const char *path, int flags)
>        strcpy(lk->filename, path);
>        /*
>         * subtract 5 from size to make sure there's room for adding
> -        * ".lock" for the lock file name
> +        * "..lck" for the lock file name
>         */
>        if (!(flags & LOCK_NODEREF))
>                resolve_symlink(lk->filename, sizeof(lk->filename)-5);
> -       strcat(lk->filename, ".lock");
> +       strcat(lk->filename, "..lck");
>        lk->fd = open(lk->filename, O_RDWR | O_CREAT | O_EXCL, 0666);

There must be at least some deprecation period during which also the old .lock lockfiles are considered and created. Just imagine someone modifying the ref with an older version, which knows nothing about ..lck.