Re: [PATCH] Wait for git diff to finish in git difftool

From: Alex Riesen <raa.lkml@gmail.com>
Date: Apr 23, 2009, 09:52 UTC
Message-ID: <81b0412b0904230252k3e8197d3y8798d5b797a49c39@mail.gmail.com>
In-Reply-To: <7vtz4fwzaz.fsf@gitster.siamese.dyndns.org>

2009/4/23 Junio C Hamano <gitster@pobox.com>:

Show 23 quoted lines

> Alex Riesen <raa.lkml@gmail.com> writes:
>
>> 2009/4/23 Junio C Hamano <gitster@pobox.com>:
>>> Alex Riesen <raa.lkml@gmail.com> writes:
>>>> Frankly, I just always forget about it. The patches to my windows
>>>> repository are mostly just hacks to either make it pass test suite or
>>>> workaround another, the platforms specific, stupidity. Not sure anyone
>>>> is actually interested in them (because, I repeat, they mostly hurt
>>>> everyone else, while making the platforms port "a little working").
>>>
>>> What do you really mean?  These patches add maintenance burden but its
>>> benefit nobody would care about, and should not be applied?
>>
>> Maintenance _and_ run-time. It is your decision, but yes, I kind of hate
>> the idea of them being applied.
>>
>> In plain words: please don't apply MY patches with words "Windows"
>> or "Cygwin" in message body, unless I beg you to (and even then,
>> consider me heavily drugged).
>
> Hmm, what's the point then for me to spend time looking at them posted on
> the list?
>

None. But it still would be nice if you look at them when you're addressed directly. Please understand, maybe I'm abusing the list a little, but it looks like the best place to _archive_ the workarounds for this obscure platform. The code is of little use to general public, but in case one finds himself in the same situation as I am in, at least Google can help out. I think it happens too rare to justify your looking at them, and especially including them in the mainline, but hiding the code on my laptop isn't of any use to anyone (including me: I don't always have that laptop).