Re: Teach git-update-index about gitlinks

From: Alex Riesen <raa.lkml@gmail.com>
Date: Apr 13, 2007, 08:14 UTC
Message-ID: <81b0412b0704130114u2a7217cep6cd77b902e92bbd8@mail.gmail.com>
In-Reply-To: <81b0412b0704130042k1f5be3bay30cbbb6b70259f6@mail.gmail.com>

On 4/13/07, Alex Riesen <raa.lkml@gmail.com> wrote:

Show 10 quoted lines

> > + *    (NOTE! This is old and arguably fairly strange behaviour.
> > + *    We might want to make this an error unconditionally, and
> > + *    use "--force-remove" if you actually want to force removal).
> ...
> > +               /* Should this be an unconditional error? */
> > +               return remove_one_path(path);
>
> Makes me uncomfortable too. Is it be possible anyone is depending
> on it? Maybe it still can be changed?
>

Maybe not. It actually makes sense: the old file (now a directory) is actually removed, so a plain --remove in its old meaning still _is_ correct: remove the file from index if it is removed from working directory. And it breaks t1001.