git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Avoid ActiveState Perl IO in t800[12]

From
Alex Riesen <raa.lkml@gmail.com>
Date
Feb 5, 2007, 13:15 UTC
Message-ID
<81b0412b0702050515s7e0efe3fm76220a6c647dbee@mail.gmail.com>

Use sed instead, it comes with cygwin and there is almost no chance of someone installing a sed with default CRLF lineendings by accident.

Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
---

I have been seeing failures in the t800x tests from the beginning on, I believe. Today they annoyed me enough to get them fixed. The reason of the failures is the usual one: for reasons unexplainable activestate perl defaults to CRLF lineendings in all output, which in the testcase changes the whole file.

 t/annotate-tests.sh |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
From c242c7ea07d98ddfb45961b52f5975d0297f9781 Mon Sep 17 00:00:00 2001
From: Alex Riesen <raa.lkml@gmail.com>
Date: Mon, 5 Feb 2007 14:04:09 +0100
Subject: [PATCH] Avoid ActiveState Perl IO in t800[12]

Use sed instead, it comes with cygwin and there is almost no chance of someone installing a sed with default CRLF lineendings by accident.

Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
---

I have been seeing failures in the t800x tests from the beginning on, I believe. Today they annoyed me enough to get them fixed. The reason of the failures is the usual one: for reasons unexplainable activestate perl defaults to CRLF lineendings in all output, which in the testcase changes the whole file.

 t/annotate-tests.sh |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/t/annotate-tests.sh b/t/annotate-tests.sh
index b5ceba4..87403da 100644
--- a/t/annotate-tests.sh
+++ b/t/annotate-tests.sh
@@ -113,7 +113,8 @@ test_expect_success \
 
 test_expect_success \
     'some edit' \
-    'perl -p -i.orig -e "s/^1A.*\n$//; s/^3A/99/" file &&
+    'mv file file.orig &&
+    sed -e "s/^3A/99/" -e "/^1A/d" < file.orig > file &&
     GIT_AUTHOR_NAME="D" git commit -a -m "edit"'
 
 test_expect_success \
-- 
1.5.0.rc3.72.g4005
Message 1 of 1 in “Avoid ActiveState Perl IO in t800[12]”
  1. Avoid ActiveState Perl IO in t800[12]Alex Riesen, Feb 5, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.