git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Commit f84871 breaks build on OS X

From
Alex Riesen <raa.lkml@gmail.com>
Date
Dec 7, 2006, 15:42 UTC
Message-ID
<81b0412b0612070742x51af6011ua96962c53158cea0@mail.gmail.com>
In-Reply-To
<E8038C15-B359-4DE9-B3E0-45B065AEDBFA@silverinsanity.com>

Does the attached patch help? I highly suspect the perl.mak generated by MakeMaker.

diff --git a/perl/Makefile b/perl/Makefile
index bd483b0..b936e0d 100644
--- a/perl/Makefile
+++ b/perl/Makefile
@@ -29,6 +29,8 @@ $(makfile): ../GIT-CFLAGS Makefile
 	echo '	echo $(instdir_SQ)' >> $@
 else
 $(makfile): Makefile.PL ../GIT-CFLAGS
+	$(RM) $(makfile)
+	$(RM) $(makfile).old
 	'$(PERL_PATH_SQ)' $< FIRST_MAKEFILE='$@' PREFIX='$(prefix_SQ)'
 endif


From 5e00f865fa13a425d4395a70aaca798dfaf093dc Mon Sep 17 00:00:00 2001
From: Alex Riesen <raa.lkml@gmail.com>
Date: Thu, 7 Dec 2006 16:40:06 +0100
Subject: [PATCH] workaround for MakeMaker-generated Makefiles

It seems to try to mv perl.mak into perl.mak.old file without checking if
.old exists first.

Signed-off-by: Alex Riesen <raa.lkml@gmail.com>

diff --git a/perl/Makefile b/perl/Makefile
index bd483b0..b936e0d 100644
--- a/perl/Makefile
+++ b/perl/Makefile
@@ -29,6 +29,8 @@ $(makfile): ../GIT-CFLAGS Makefile
 	echo '	echo $(instdir_SQ)' >> $@
 else
 $(makfile): Makefile.PL ../GIT-CFLAGS
+	$(RM) $(makfile)
+	$(RM) $(makfile).old
 	'$(PERL_PATH_SQ)' $< FIRST_MAKEFILE='$@' PREFIX='$(prefix_SQ)'
 endif
 
Previous: Brian Gernhardt
Message 12 of 12 in “Commit f84871 breaks build on OS X”
  1. Brian GernhardtDec 7, 2006
  2. Alex RiesenDec 7, 2006
  3. PazuDec 7, 2006
  4. Randal L. SchwartzDec 7, 2006
  5. Junio C HamanoDec 7, 2006
  6. Junio C HamanoDec 7, 2006
  7. Alex RiesenDec 8, 2006
  8. Brian GernhardtDec 8, 2006
  9. Johannes SchindelinDec 7, 2006
  10. Andreas EricssonDec 7, 2006
  11. Brian GernhardtDec 7, 2006
  12. Alex RiesenDec 7, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.