Re: PATCH: simplify calls to git programs in git-fmt-merge-msg

From: Alex Riesen <raa.lkml@gmail.com>
Date: Feb 23, 2006, 10:57 UTC
Message-ID: <81b0412b0602230257h3713e6e8ud11c6aa9547b0d37@mail.gmail.com>
In-Reply-To: <7vslqaicqj.fsf@assigned-by-dhcp.cox.net>

On 2/23/06, Junio C Hamano <junkio@cox.net> wrote:

Show 8 quoted lines

>
> > It also makes it work on ActiveState Perl.
> >
> > ---
>
> ActiveState or not, this simplification is pretty much welcomed.
> The only problem I _might_ have later is with shortlog, though I
> have not looked at it closely yet.

I tested it a bit.
I suppose you can have two following concerns there:
- $tip - it seem to be always an sha1
- perl can decide to fetch whole output of git-log into memory.
  I heard it optimizes such cases into reading only when needed...