Re: [PATCH] fmt-merge-msg: avoid open "-|" list form for Perl 5.6
- From
Alex Riesen <raa.lkml@gmail.com>
- Date
- Feb 23, 2006, 09:41 UTC
- Message-ID
- <81b0412b0602230141g46dbfaev6baa5083dee2d42@mail.gmail.com>
- In-Reply-To
- <81b0412b0602230135w472aa6f3v72980f6f63bb355f@mail.gmail.com>
On 2/23/06, Alex Riesen <raa.lkml@gmail.com> wrote:
Show 11 quoted lines
> On 2/23/06, Junio C Hamano <junkio@cox.net> wrote: > > "Alex Riesen" <raa.lkml@gmail.com> writes: > > > > > I'll keep that in mind. But there are places where a safe pipe is unavoidable > > > (filenames. No amount of careful quoting will save you). > > > > Huh? > > Because you never know what did the next interpreter took for unquoting: > $SHELL, /bin/sh cmd /c, or something else. >
And that stupid activestate thing actually doesn't use any. Just tried:
perl -e '$,=" ";open(F, "sleep 1000 ; # @ARGV |") and print <F>'
It passed the whole string "1000 ; # @ARGV" to sleep from $PATH. It failed to sleep at all, of course. The same code works perfectly on almost any UNIX system.