git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Fix git.c compilation target

From
Alex Riesen <raa.lkml@gmail.com>
Date
Nov 21, 2005, 08:10 UTC
Message-ID
<81b0412b0511210010m66a3f898q6d108a799de023d9@mail.gmail.com>

The target for "git" was missing $(X), strangely essential for some exotic platform.

Signed-off-by: Alex Riesen <ariesen@harmanbecker.com>
Subject: [PATCH] fix compilation of git(.exe)
(cherry picked from b0911b2af7c52639a2c6ae8f038ba5753f886a28 commit)
Signed-off-by: Alex Riesen <ariesen@harmanbecker.com>
---
 Makefile |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

applies-to: e12ceef6841365e64bb765294235a67e9263d7de 2323c0467c437c337c0ad59e9660ccea920ff866

diff --git a/Makefile b/Makefile
index 092931a..65b948b 100644
--- a/Makefile
+++ b/Makefile
@@ -342,15 +342,15 @@ SCRIPTS = $(patsubst %.sh,%,$(SCRIPT_SH)
 export prefix TAR INSTALL DESTDIR SHELL_PATH template_dir
 ### Build rules
 
-all: $(PROGRAMS) $(SCRIPTS) git
+all: $(PROGRAMS) $(SCRIPTS) git$(X)
 
 all:
 	$(MAKE) -C templates
 
 # Only use $(CFLAGS). We don't need anything else.
-git: git.c Makefile
+git$(X): git.c Makefile
 	$(CC) -DGIT_EXEC_PATH='"$(bindir)"' -DGIT_VERSION='"$(GIT_VERSION)"' \
-		$(CFLAGS) $@.c -o $@
+		$(CFLAGS) $< -o $@
 
 $(filter-out git,$(patsubst %.sh,%,$(SCRIPT_SH))) : % : %.sh
 	rm -f $@
---
0.99.9.GIT
Next: Alex Riesen
Message 1 of 6 in “Fix git.c compilation target”
  1. Fix git.c compilation targetAlex Riesen, Nov 21, 2005
  2. Alex RiesenNov 21, 2005
  3. Junio C HamanoNov 21, 2005
  4. Re: [PATCH] Fix git.c compilation targetAndreas Ericsson, Nov 21, 2005
  5. Alex RiesenNov 22, 2005
  6. Junio C HamanoNov 22, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.