git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/4] Initialize a few uninitialized variables

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Jul 17, 2025, 16:45 UTC
Message-ID
<819d0360-5e99-b2ac-5bc3-50bf9bf95662@gmx.de>
In-Reply-To
<pull.1888.git.1743079429.gitgitgadget@gmail.com>
Hi,
On Thu, 27 Mar 2025, Johannes Schindelin via GitGitGadget wrote:
> When I ran CodeQL on Git's source code, it said that that variables might be
> uninitialized in a few places.

For the record, I am abandoning my efforts to upstream this. I was never interested in the actual changes, I was interested in getting CodeQL to run on Git's code base without reporting false positives, so that I could compare the quality of the reports against Coverity's. Therefore, I was not really prepared to polish these patches as if they were something important: They are not, and I cannot justify spending any more time on these patches. I will carry them as-are in microsoft/git, under the label 'uninitialized-variables', as long as they apply without major merge conflict headaches.

Ciao, Johannes

Previous: Taylor Blau
Message 10 of 10 in “Initialize a few uninitialized variables”
  1. 0/4 Initialize a few uninitialized variablesJohannes Schindelin via GitGitGadget, Mar 27, 2025
  2. 1/4 cat_one_file(): make it easy to see that the `size` variable is initializedJohannes Schindelin via GitGitGadget, Mar 27, 2025
  3. Jeff KingMar 28, 2025
  4. 2/4 fsck: avoid using an uninitialized variableJohannes Schindelin via GitGitGadget, Mar 27, 2025
  5. Jeff KingMar 28, 2025
  6. 3/4 load_revindex_from_disk(): avoid accessing uninitialized dataJohannes Schindelin via GitGitGadget, Mar 27, 2025
  7. Taylor BlauMar 27, 2025
  8. 4/4 load_pack_mtimes_file(): avoid accessing uninitialized dataJohannes Schindelin via GitGitGadget, Mar 27, 2025
  9. Taylor BlauMar 27, 2025
  10. Johannes SchindelinJul 17, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.