Re: [PATCH v2 2/4] git gui: set GIT_ASKPASS=git-gui--askpass if not set yet

From: Johannes Sixt <j6t@kdbg.org>
Date: Aug 28, 2025, 17:44 UTC
Message-ID: <816cd946-4f25-4ce8-aa06-6babf9e90751@kdbg.org>
In-Reply-To: <e1aef533bfe89bfb87b1a83bf7c7375e6238b06f.1756371530.git.gitgitgadget@gmail.com>

Am 28.08.25 um 10:58 schrieb Johannes Schindelin via GitGitGadget:

Show 6 quoted lines

> @@ -1130,6 +1130,9 @@ set argv0dir [file dirname [file normalize $::argv0]]
>  if {![info exists env(SSH_ASKPASS)]} {
>  	set env(SSH_ASKPASS) [file join $argv0dir git-gui--askpass]
>  }
> +if {![info exists env(GIT_ASKPASS)]} {
> +	set env(GIT_ASKPASS) [gitexec git-gui--askpass]

Is this [gitexec ...] deliberate, or can this be [file join ...] like in the surrounding cases? If it is deliberate, we need an updated commit message and/or a comment, otherwise, I can amend locally while queuing.

> +}
>  if {![info exists env(GIT_ASK_YESNO)]} {
>  	set env(GIT_ASK_YESNO) [file join $argv0dir git-gui--askyesno]
>  }