git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4 3/4] cache-tree: fix writing cache-tree when CE_REMOVE is present

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 16, 2012, 10:38 UTC
Message-ID
<80fec1df-83ec-4634-b06e-27369949af94@email.android.com>
In-Reply-To
<CACsJy8DgwQ2jn=tPpE8f22JNE1Vih86d=Xf1iGBznLcwMukd+w@mail.gmail.com>
Nguyen Thai Ngoc Duy <pclouds@gmail.com> wrote:
Show 8 quoted lines
>On Sun, Dec 16, 2012 at 2:20 PM, Junio C Hamano <gitster@pobox.com>
>wrote:
>> Nicely explained.  I wonder if we can also add a piece of test to
>> the patch 4/4 to demonstrate the issue with CE_REMOVE entries,
>> though.
>
>A hand crafted one, maybe. I did not attempt to recreate it with git
>commands (and I don't think we update cache-tree after unpack_trees).
Yeah, that's what I thought. No need to bother creating a bug that won't appear in the real life :-) 
Tusks for sanity checking.
-- 
Pardon terseness, typo and HTML from a tablet.
Previous: Nguyen Thai Ngoc DuyNext: Nguyễn Thái Ngọc Duy
Message 7 of 8 in “nd/invalidate-i-t-a-cache-tree”
  1. 0/4 nd/invalidate-i-t-a-cache-treeNguyễn Thái Ngọc Duy, Dec 16, 2012
  2. 1/4 cache-tree: remove dead i-t-a code in verify_cache()Nguyễn Thái Ngọc Duy, Dec 16, 2012
  3. 2/4 cache-tree: replace "for" loops in update_one with "while" loopsNguyễn Thái Ngọc Duy, Dec 16, 2012
  4. 3/4 cache-tree: fix writing cache-tree when CE_REMOVE is presentNguyễn Thái Ngọc Duy, Dec 16, 2012
  5. Junio C HamanoDec 16, 2012
  6. Nguyen Thai Ngoc DuyDec 16, 2012
  7. Junio C HamanoDec 16, 2012
  8. 4/4 cache-tree: invalidate i-t-a paths after generating treesNguyễn Thái Ngọc Duy, Dec 16, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.