git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] midx: traverse the local MIDX first

From
Derrick Stolee <stolee@gmail.com>
Date
Aug 28, 2020, 19:03 UTC
Message-ID
<80ba7515-dc6c-3acd-4b53-c60cbdab1633@gmail.com>
In-Reply-To
<20200828185531.GB2171353@coredump.intra.peff.net>
On 8/28/2020 2:55 PM, Jeff King wrote:
Show 13 quoted lines
> On Fri, Aug 28, 2020 at 02:50:39PM -0400, Jeff King wrote:
> 
>> So I'd be tempted to say that the latter callers should be using a
>> separate function that gives them what they want. That lets them avoid
>> being too intimate with the details of how we order things.
>>
>> The patch below illustrates that.  It also changes the existing function
>> name to avoid confusion and to help audit the existing callers, but
>> that's optional and maybe not worth it.
> 
> And here's the same concept as a more minimal change, suitable for
> squashing into yours. The advantage is that it keeps the "the local one
> goes first" logic in one abstracted spot.

This is nice because it is more future-proof: if we needed to change the order of the midx list, then we could update the implementation of this method instead of every caller.

Personally, I prefer this one (squashed).

Thanks, -Stolee

Previous: Jeff KingNext: Taylor Blau
Message 5 of 10 in “midx: traverse the local MIDX first”
  1. midx: traverse the local MIDX firstTaylor Blau, Aug 28, 2020
  2. Derrick StoleeAug 28, 2020
  3. Jeff KingAug 28, 2020
  4. Jeff KingAug 28, 2020
  5. Derrick StoleeAug 28, 2020
  6. Taylor BlauAug 28, 2020
  7. Jeff KingAug 28, 2020
  8. Taylor BlauAug 28, 2020
  9. midx: traverse the local MIDX firstTaylor Blau, Aug 28, 2020
  10. Jeff KingAug 28, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.