Re: git-send-pack segfaulting on DebianPPC

From: Junio C Hamano <junkio@cox.net>
Date: Oct 19, 2005, 21:15 UTC
Message-ID: <7vzmp52oor.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <46a038f90510191356w56b78413p6b9fe5b67fc9ee74@mail.gmail.com>

Martin Langhoff <martin.langhoff@gmail.com> writes:

> There is a second bug during the tag fetch. Some of the references
> (created by git-cvsimport) are multiline, and break cg-fetch. It's
> probably a bug in git-cvsimport, but I'm fixing cg-fetch to use head
> -n1 instead of cat. I'll deal with git-cvsimport later.

When you update git-cvsimport, please make the tags it generates git-check-ref-format happy. The rules are:

 - No pathname component starting with a dot '.' (cg-fetch uses
   refs/heads/.$name-fetching to store the SHA1 it has not fully
   completed; for_each_ref() deliberately ignores path component
   that start with a dot to ignore them, probably to work this
   around).

 - No double-dots anywhere (ref1..ref2 notation is used on the
   command line and ref with embedded double-dots introduces
   ambiguities in parsing).

 - No byte with value lower than \040 (SP) nor \177 (DEL).

 - No tilde '~', caret '^' or colon ':' (the first two are used
   in extended SHA1 expressions; colon is used as src:dst
   notation in push and pull).

 - Not ending with a slash '/'.

> On this broken-ish repo, git-fetch-pack segfaults as I've reported.
> Running it under strace shows that it dies walking the local repo,
> trying to find a missing commit. Unlikely that this is PPC only ;-)