git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Fix race and deadlock when sending pack

From
Junio C Hamano <junkio@cox.net>
Date
Dec 19, 2005, 05:36 UTC
Message-ID
<7vzmmxlkbq.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<43A628F6.1060807@serice.net>
Paul Serice <paul@serice.net> writes:
Show 6 quoted lines
> The best way to reproduce the problem is to locally clone your
> repository.  When you perform a push, git-send-pack will directly set
> up pipes connected to stdin and stdout of git-receive-pack.  You
> should then set up hook/post-update or hook/update to try to write
> lots of text to stdout.  (You want to use the local protocol because
> ssh is robust enough to mask the worst behavior.)

My immediate reaction was "do not do it then", but you are right. Hooks are run after all the protocol exchanges are done, so they should be free to throw any garbage at the other end.

It appears cpfd() seems to mostly duplicate what is in copy.c; is there any particular reason?

Previous: Paul SericeNext: Paul Serice
Message 2 of 10 in “Fix race and deadlock when sending pack”
  1. Fix race and deadlock when sending packPaul Serice, Dec 19, 2005
  2. Junio C HamanoDec 19, 2005
  3. Paul SericeDec 19, 2005
  4. Daniel BarkalowDec 19, 2005
  5. Junio C HamanoDec 19, 2005
  6. Daniel BarkalowDec 19, 2005
  7. Junio C HamanoDec 19, 2005
  8. Daniel BarkalowDec 19, 2005
  9. Junio C HamanoDec 19, 2005
  10. Paul SericeDec 19, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.