Re: [PATCH 2/3] sha1_file: add the ability to parse objects in "pack file format"
- From
Junio C Hamano <junkio@cox.net>
- Date
- Jul 12, 2006, 06:35 UTC
- Message-ID
- <7vzmffz5xe.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <Pine.LNX.4.64.0607111755180.5623@g5.osdl.org>
Linus Torvalds <torvalds@osdl.org> writes:
Show 6 quoted lines
> I shouldn't have introduced the new TYPE_xxx macros. I should just have > used the same OBJ_xxx macros that we use in the pack-file. > > Junio: this patch is totally independent from the other patches, and is on > top of you current "master". It gets rid of TYPE_xxx in favor of the > OBJ_xxx enums, which are moved from pack.h into object.h.
You seem to have forgotten one file (fetch-pack.c) but that was trivial. I'll apply and push it out shortly.
This might collide with a few topic branches but I have rerere to help me cope with it ;-).