Re: [PATCH] gitweb: Use the git binary in the search path by default

From: Junio C Hamano <junkio@cox.net>
Date: Jul 11, 2006, 19:56 UTC
Message-ID: <7vzmff3ogn.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <11526131791902-git-send-email-alp@atoker.com>

Alp Toker <alp@atoker.com> writes:

> Introduce a sensible default for the location of the git binary used by
> gitweb. This means one less option to configure when deploying gitweb if
> git is in the search path.

While I think the part of the change to make things go through the single "git" wrapper is a good idea, the comment to "our $GIT" that says "absolute path is optional" makes this change more like "assume PATH your webserver process uses is sensible", not "introduce a sensible default".

So I would prefer to do that part like this:

-# location of the git-core binaries -our $gitbin = "/usr/bin"; +# core git wrapper -- if your webserver runs with a sensible PATH +# you can just say "git" without using absolute pathname here. +our $GIT = "/usr/bin/git";