Re: [PATCH 2/3] gitweb: Allow for href() to be used for projectless links
- From
Junio C Hamano <junkio@cox.net>
- Date
- Sep 15, 2006, 06:17 UTC
- Message-ID
- <7vzmd1zma7.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <200609150457.16924.jnareb@gmail.com>
Jakub Narebski <jnareb@gmail.com> writes:
Show 5 quoted lines
> Change adding project to params if $params{"project"} is false
> to adding project to params if it not exist. It allows for href()
> to be used for projectless links by using "project=>undef" as
> argument, while still adding project to params by default
> in the most common case.This did not parse very well, at least for me.
Show 14 quoted lines
> @@ -1304,9 +1305,11 @@ sub git_footer_html {
> if (defined $descr) {
> print "<div class=\"page_footer_text\">" . esc_html($descr) . "</div>\n";
> }
> - print $cgi->a({-href => href(action=>"rss"), -class => "rss_logo"}, "RSS") . "\n";
> + print $cgi->a({-href => href(action=>"rss"),
> + -class => "rss_logo"}, "RSS") . "\n";
> } else {
> - print $cgi->a({-href => href(action=>"opml"), -class => "rss_logo"}, "OPML") . "\n";
> + print $cgi->a({-href => href(project=>undef, action=>"opml"),
> + -class => "rss_logo"}, "OPML") . "\n";
> }
> print "</div>\n" .
> "</body>\n" .Argh. While I very much welcome folding of the long lines, I'd rather see a separate patch to clean up other loooooooong lines the current gitweb code has.