Re: [PATCH] gitweb: fix warnings in PATH_INFO code and add export_ok/strict_export
- From
Junio C Hamano <junkio@cox.net>
- Date
- Sep 17, 2006, 23:10 UTC
- Message-ID
- <7vzmcy143n.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <eekj5b$rlc$1@sea.gmane.org>
Jakub Narebski <jnareb@gmail.com> writes:
Show 17 quoted lines
> Junio C Hamano wrote: > >> Matthias Lederhofer <matled@gmx.net> writes: >> >>> This patch replaces the other two warning fixes by Jakub and me. I've >>> put the whole thing in a sub-routine to keep the indentation level >>> low. >> >> Looks much cleaner with this extra sub. >> >> This does not seem have the "colon as a cue that the URL is also >> talking about a branch", Jakub's summary of the discussion >> between you two on #git channel. I think that proposal makes >> sense as well. > > Well, that is because this patch _predates_ the discussion > (and proposal/conclusions).
Yup, I know, I was not complaining.
I was saying that I do not oppose to a follow-up patch to add that "colon" stuff.