git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Fix buggy ref recording

From
Junio C Hamano <junkio@cox.net>
Date
Sep 23, 2006, 00:44 UTC
Message-ID
<7vzmcrxvgw.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<20060922230845.GB8259@pasky.or.cz>
Petr Baudis <pasky@suse.cz> writes:
> And since just reporting it did not magically result in a fix... ;-)

Yes, please always send in a patch to be applied to get the attribution right.

I've never seen you send out a corrupt patch over e-mail. What's different this time?

Show 8 quoted lines
> diff --git a/refs.c b/refs.c
> index 40f16af..5fdf9c4 100644
> --- a/refs.c
> +++ b/refs.c
> @@ -472,7 +472,7 @@ static struct ref_lock *lock_ref_sha1_ba
>
>  	lock->ref_name = xstrdup(ref);
>  	lock->log_file = xstrdup(git_path("logs/%s", ref));

The empty line at the beginning of the hunk is totally empty, not even with a SP to show it is a context line.

Will hand-apply, no need to resend.
Previous: Petr BaudisNext: Petr Baudis
Message 6 of 8 in “Enable the packed refs file format”
  1. Linus TorvaldsSep 14, 2006
  2. Petr BaudisSep 19, 2006
  3. Linus TorvaldsSep 19, 2006
  4. Phil RichardsSep 20, 2006
  5. Fix buggy ref recordingPetr Baudis, Sep 22, 2006
  6. Junio C HamanoSep 23, 2006
  7. Petr BaudisSep 23, 2006
  8. pack-refs: fix git_path() usage.Junio C Hamano, Sep 23, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.