Re: [RFC/PATCH 1/2] Add a useful return value to git-check-attr
- From
Junio C Hamano <junkio@cox.net>
- Date
- Apr 17, 2007, 09:28 UTC
- Message-ID
- <7vzm57pcxp.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <200704171010.49168.andyparkins@gmail.com>
Andy Parkins <andyparkins@gmail.com> writes:
Show 7 quoted lines
> git-check-attr previously always returned success. With this patch it > returns success when the requested attribute is found for all supplied > paths. > > This lets you check in a script whether a file has an attribute: > > $ git-check-attr attribute -- file && echo "file has attribute"
I wrote check-attr primarily to have a quick way to make sure the attribute stack is working properly, but I agree making gitattributes available to scripts is important to make it useful in general.
And your patch was a step in the right direction based on my previous patch.
But sorry, you were shooting at a target that is still moving too fast, and you missed. It's not your fault, as even I did not know where it was heading to, but my plan has been to have the scripts parse the text output, as we would need more than true/false values, as I did in the four patch series I sent out tonight.