git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/8] git-repack --max-pack-size: add new file statics

From
Junio C Hamano <junkio@cox.net>
Date
May 1, 2007, 04:11 UTC
Message-ID
<7vzm4p89op.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<4636790C.5060908@gmail.com>
Dana How <danahow@gmail.com> writes:
Show 34 quoted lines
> This adds "pack_size_limit", which will contain the limit
> specified by --max-pack-size, "written_list", the actual
> list of objects written to the current pack, and "nr_written",
> the number of objects in written_list.
>
> Signed-off-by: Dana L. How <danahow@gmail.com>
> ---
>  builtin-pack-objects.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/builtin-pack-objects.c b/builtin-pack-objects.c
> index b827627..ac2c15e 100644
> --- a/builtin-pack-objects.c
> +++ b/builtin-pack-objects.c
> @@ -52,7 +52,8 @@ struct object_entry {
>   * nice "minimum seek" order.
>   */
>  static struct object_entry *objects;
> -static uint32_t nr_objects, nr_alloc, nr_result;
> +static struct object_entry **written_list;
> +static uint32_t nr_objects, nr_alloc, nr_result, nr_written;
>  
>  static int non_empty;
>  static int no_reuse_delta;
> @@ -64,6 +65,7 @@ static char tmpname[PATH_MAX];
>  static unsigned char pack_file_sha1[20];
>  static int progress = 1;
>  static int window = 10;
> +static uint32_t pack_size_limit;
>  static int pack_to_stdout;
>  static int num_preferred_base;
>  static struct progress progress_state;
> -- 
> 1.5.2.rc0.766.gba60-dirty

This by itself does not seem to do anything (no logic, no command line option parsing, nothing). Why is this a separate patch?

Previous: Dana HowNext: Dana How
Message 2 of 3 in “git-repack --max-pack-size: add new file statics”
  1. 1/8 git-repack --max-pack-size: add new file staticsDana How, Apr 30, 2007
  2. Junio C HamanoMay 1, 2007
  3. Dana HowMay 1, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.