Re: [PATCH] Correct usages of sed in git-tag for Mac OS X
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 30, 2007, 07:00 UTC
- Message-ID
- <7vzm2ic4g8.fsf@assigned-by-dhcp.pobox.com>
- In-Reply-To
- <20070630064247.GA18041@spearce.org>
"Shawn O. Pearce" <spearce@spearce.org> writes:
> These major Git functions are much more important than > saving two or three lines of a simple sed script.
The size of the script does not worry me. The number of sed processes originally did, but the old code also had two invocations of sed, and I do not think you can implement the "strip the header, and then emit ${LINES} lines" behaviour without doing them in separate sed anyway, so I think this is fine. But it makes me wonder why we are not using awk ;-)