Re: gitk fails to parse git log output in 1.5.3
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Sep 2, 2007, 23:16 UTC
- Message-ID
- <7vzm04odze.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <20070902223128.GA19198@falcon.digizenstudio.com>
Jing Xue <jingxue@digizenstudio.com> writes:
Show 7 quoted lines
> gitk shows an error "Can't parse git log output: {\x1b[33commit..." at
> startup and quits.
>
> Obviously it's because my git-log outputs in color mode. But the same
> happens (and git-log still outputs in colors) after I set color.pager=false.
>
> What am I missing?This will quickly turn into an FAQ.
Please see:
http://thread.gmane.org/gmane.comp.version-control.git/57204
for details and a possible future plans. Making "diff.color = true" to always color was a mistake, and if you have such a configuration, it would break any script that reads from "git log". In the meantime, do not do "diff.color = true" (or "color.diff = true") in your configuration; say "auto" instead of "true", and/or apply this patch.
---
gitk | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/gitk b/gitk index 300fdce..9c21eff 100755 --- a/gitk +++ b/gitk @@ -93,6 +93,7 @@ proc start_rev_list {view} { } if {[catch { set fd [open [concat | git log -z --pretty=raw $order --parents \ + --no-color \ --boundary $viewargs($view) "--" $viewfiles($view)] r] } err]} { error_popup "Error executing git rev-list: $err"