Re: [RFC] svnimport/cvsimport: force creation of tags that already exist.

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 7, 2007, 20:54 UTC
Message-ID: <7vzlzy2o46.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <Pine.LNX.4.64.0709071125090.6203@juice.ott.cti.com>

Michael Smith <msmith@cbnco.com> writes:

> I understand moving tags is frowned upon in Git. I don't know how common 
> the practise is in Subversion and CVS, or whether it makes sense to 
> make the import scripts force tag creation by default.

I think the patch itself makes sense. If for some reason the importer detects that the CVS or SVN history moved a tag, we either:

    (1) have a way to keep track of the versions of the tag; or
    (2) allow it and make it "last one wins" semantics; or
    (3) ignore it and make it "first one wins" semantics.

Erroring out complaining that the tag cannot be created, as the current code does, does not make any sense.

The patch needs to be accompanied with a better commit log description. I am guessing that with your change the semantics would become (2) above (assuming that cvsps or whoever reads the history of the other side gives events in chronological order), but you should not force readers of your commit log message to guess.