git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] rebase: add --signoff option

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 1, 2007, 08:20 UTC
Message-ID
<7vzlz3s0tv.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<11911689111797-git-send-email-prohaska@zib.de>
Steffen Prohaska <prohaska@zib.de> writes:
Show 11 quoted lines
> When preparing a series of commits for upstream you may
> need to signoff commits if you forgot to do so earlier.
> This patch teaches git-rebase to signoff during rebase
> if you pass the option --signoff.
>
> Notes
> 1) --signoff cannot be used simultaneously with --interactive.
> 2) --signoff forces a rebase even if current path is a
>    descendant of <upstream>.
>
> Signed-off-by: Steffen Prohaska <prohaska@zib.de>

I do not think it is fatal for --signoff to be incompatible with the "interactive" mode is fatal, but lack of mention in the documentation is. Also this would need test scripts to prevent it from getting broken by future changes by others. I'd like to see ones that test at least the cases where (1) nobody has sign-off, (2) you do not have sign-off but others do, and (3) you already have sign-off at the end.

But I do like the general concept.
Previous: Steffen Prohaska
Message 6 of 6 in “rebase: add --signoff option”
  1. rebase: add --signoff optionSteffen Prohaska, Sep 30, 2007
  2. Johannes SchindelinSep 30, 2007
  3. Steffen ProhaskaSep 30, 2007
  4. Johannes SchindelinSep 30, 2007
  5. Steffen ProhaskaOct 1, 2007
  6. Junio C HamanoOct 1, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.