Re: [PATCH] builtin-reflog.c: typo ref --> argv[i], could cause segfault

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 5, 2008, 01:22 UTC
Message-ID: <7vzlvlf4n9.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <477ED949.1030909@nrlssc.navy.mil>

Brandon Casey <casey@nrlssc.navy.mil> writes:

Show 17 quoted lines

> Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil>
> ---
>  builtin-reflog.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/builtin-reflog.c b/builtin-reflog.c
> index f422693..5e54989 100644
> --- a/builtin-reflog.c
> +++ b/builtin-reflog.c
> @@ -394,7 +394,7 @@ static int cmd_reflog_delete(int argc, const char **argv, const char *prefix)
>  		int recno;
>  
>  		if (!spec) {
> -			status |= error("Not a reflog: %s", ref);
> +			status |= error("Not a reflog: %s", argv[i]);
>  			continue;
>  		}

Bad Brandon! Looking at 'next' while everybody is asked to work on finding and fixing bugs on 'master' while -rc freeze.

Just kidding. Thanks, the code is obviously correct, and will queue.

I am not so surprised to see bugs in relatively new code that is only in 'next', especially this one that no Porcelains already use.