Re: [PATCH 1/1] Fix recipient santitization
- From
Junio C Hamano <gitster@pobox.com>
- Date
- May 21, 2008, 19:38 UTC
- Message-ID
- <7vzlqj1m8x.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <1206713344-11244-1-git-send-email-vonbrand@inf.utfsm.cl>
Last night I was going through old mail-logs and found this, which I think still is needed. Does anybody see anything wrong with the patch (aside from missing full-stop at the end of the sentence)?
"Horst H. von Brand" <vonbrand@inf.utfsm.cl> writes:
Show 22 quoted lines
> Need to quote all special characters, not just the first one
>
> Signed-off-by: Horst H. von Brand <vonbrand@inf.utfsm.cl>
> ---
> git-send-email.perl | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/git-send-email.perl b/git-send-email.perl
> index f62f119..3bdd225 100755
> --- a/git-send-email.perl
> +++ b/git-send-email.perl
> @@ -635,7 +635,7 @@ sub sanitize_address
>
> # double quotes are needed if specials or CTLs are included
> elsif ($recipient_name =~ /[][()<>@,;:\\".\000-\037\177]/) {
> - $recipient_name =~ s/(["\\\r])/\\$1/;
> + $recipient_name =~ s/(["\\\r])/\\$1/g;
> $recipient_name = "\"$recipient_name\"";
> }
>
> --
> 1.5.5.rc2