git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [bug] Segfault in git rev-list --first-parent --bisect

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 23, 2008, 05:31 UTC
Message-ID
<7vzln42t7o.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<7v7ia848aa.fsf@gitster.siamese.dyndns.org>
Junio C Hamano <gitster@pobox.com> writes:
Show 6 quoted lines
> "Avery Pennarun" <apenwarr@gmail.com> writes:
>
>>     $ git rev-list --first-parent --bisect 5109c91 ^d798a2bfe094
>>     Segmentation fault
>
> Totally untested, usefulness fairly unknown.

The latter part of this statement needs a bit of explanation. I do not mean "--first-parent --bisect" is useless. What I meant is that the approach is only catering to --first-parent and not about non-standard way to limit the list such as --since, --max-count, etc.

The current bisection algorithm only pays attention to the pathspec based history simplification and bottom..top (aka "UNINTERESTING or not"). A proper fix to handle these cases should work inside do_find_bisection(), and count_interesting_parents() instead of hiding the parents away that first_parent traversal did not touch, like the patch I sent out.

Previous: Junio C Hamano
Message 4 of 4 in “[bug] Segfault in git rev-list --first-parent --bisect”
  1. Avery PennarunAug 23, 2008
  2. Junio C HamanoAug 23, 2008
  3. Junio C HamanoAug 23, 2008
  4. Junio C HamanoAug 23, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.