git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC Redux] strbuf: Add method to convert byte-size to human readable form

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 19, 2008, 20:32 UTC
Message-ID
<7vzlm3ri50.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<48D3CBBA.8060507@griep.us>
Marcus Griep <marcus@griep.us> writes:
> If there is no comment on this, Junio, would you be ok accepting this as
> a patch, even as a feature-branch on pu or next?

We (collectively as the development community) should be doing better than that. "No comment" should not mean "no objection with huge silent support". "No comment" simply means "no support".

If I recall correctly (I did read the patch myself when it was posted), I did not spot anything glaringly wrong in it, but I have to go back to make sure if we are going to queue this in 'next'.

I have deliberately been trying to keep myself from commenting on series that I have read. The thing is, it seems to me that that seeing my comments on the list somehow discourages others from reviewing and commenting, and I would really like to see people on the list to review and help improve more patches from others.

Previous: Marcus GriepNext: Daniel Barkalow
Message 3 of 6 in “[RFC Redux] strbuf: Add method to convert byte-size to human readable form”
  1. Marcus GriepSep 13, 2008
  2. Marcus GriepSep 19, 2008
  3. Junio C HamanoSep 19, 2008
  4. Daniel BarkalowSep 19, 2008
  5. Junio C HamanoSep 19, 2008
  6. Junio C HamanoSep 19, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.