git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: git-format-patch patch

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 18, 2008, 08:42 UTC
Message-ID
<7vzlitho1o.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<20081218083515.GB29356@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 7 quoted lines
> ... Besides the format not being applicable by regular git tools:
>
>  - there is no commit message describing the changes, nor the reasoning
>    behind them
>
>  - it was not sent to the maintainer (who does read the list, but does
>    not always read every message).

Actually, it would probably be a good idea not to send your first patch to me and instead to request for comments from the list ;-)n

The worst offence of the message was the choice of bad Subject that strongly encouraged anyone to skip it. Consider:

	Subject: [PATCH] document "format-patch --in-reply-to" better
or something like that.
Previous: Jeff KingNext: jidanni@jidanni.org
Message 4 of 18 in “git-format-patch patch”
  1. jidanni@jidanni.orgDec 17, 2008
  2. Miklos VajnaDec 17, 2008
  3. Jeff KingDec 18, 2008
  4. Junio C HamanoDec 18, 2008
  5. Clarify git-format-patch --in-reply-tojidanni@jidanni.org, Dec 19, 2008
  6. Nanako ShiraishiDec 19, 2008
  7. Miklos VajnaDec 19, 2008
  8. Junio C HamanoDec 19, 2008
  9. SubmittingPatches: mention the usage of real name in Signed-off-by: linesMiklos Vajna, Dec 20, 2008
  10. Junio C HamanoDec 20, 2008
  11. SubmittingPatches: mention the usage of real name in Signed-off-by: linesMiklos Vajna, Dec 20, 2008
  12. jidanni@jidanni.orgDec 19, 2008
  13. Miklos VajnaDec 19, 2008
  14. just can't live without a user.namejidanni@jidanni.org, Dec 19, 2008
  15. Miklos VajnaDec 20, 2008
  16. Junio C HamanoDec 20, 2008
  17. jidanni@jidanni.orgDec 20, 2008
  18. Bernt HansenDec 19, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.