git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH (resend) 2/2] difftool: put the cursor on the editable file for Vim

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 19, 2009, 06:43 UTC
Message-ID
<7vzlhnre1w.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<1232343269-27665-1-git-send-email-davvid@gmail.com>
Ok, I see you updated from r to l.

Please do not mark such "an earlier one had a thinko, and here is a corrected patch" as "resend". It is confusing, because "resend" usually means "I sent this earlier but somehow it did not reach the list, so here is another copy verbatim."

Instead, please add a sentence or two after "---" lines to explain the situation, like...

    You only need to edit worktree files when comparing against
    the worktree.  Put the cursor automatically into its window for
    vimdiff and gvimdiff to avoid doing <C-w>r every time.
    Signed-off-by: David Aguilar <davvid@gmail.com>
    ---
    Markus pointed out that 'l' is not left (it is right as in vi key
    bindings).
     contrib/difftool/git-difftool-helper |    8 ++++++--
     1 files changed, 6 insertions(+), 2 deletions(-)

and say "[PATCH 2/2 (corrected)]" so that I can easily tell which one was a dud and which one I should take.

This time it wasn't confusing because the exchange between Markus and you were the only unread messages before your three patches in my mailbox, but you are not always that lucky.

Will take your original 1/2 and this one.
Thanks.
Previous: David Aguilar
Message 2 of 2 in “difftool: put the cursor on the editable file for Vim”
  1. 2/2 difftool: put the cursor on the editable file for VimDavid Aguilar, Jan 19, 2009
  2. Junio C HamanoJan 19, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.