git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] fix sample update hook, disable overwriting of existing tags

From
Junio C Hamano <gitster@pobox.com>
Date
May 8, 2009, 00:05 UTC
Message-ID
<7vzldobgrm.fsf@alter.siamese.dyndns.org>
In-Reply-To
<20090507164023.GB5807@macbook.lan>
Heiko Voigt <hvoigt@hvoigt.net> writes:
> Because no special rule for this existed it was allowed by default

I do not disagree that it is a good thing to be able to reject overwriting, but I do not think it is a _fix_. allowdeletetag is about _deletion_ and it already is covered by the code, isn't it?

I think it would make more sense to introduce $allowmodifytag and reject such pushes in the codepath you touched.

Previous: Heiko VoigtNext: Heiko Voigt
Message 2 of 3 in “fix sample update hook, disable overwriting of existing tags”
  1. fix sample update hook, disable overwriting of existing tagsHeiko Voigt, May 7, 2009
  2. Junio C HamanoMay 8, 2009
  3. Extend sample update hook, disable modifying of existing tagsHeiko Voigt, May 8, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.