Re: [PATCH] Add a notice that only certain functions can print color escape codes

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 27, 2009, 07:30 UTC
Message-ID: <7vzl68v2zb.fsf@alter.siamese.dyndns.org>
In-Reply-To: <4B0F78F1.4040101@viscovery.net>

Johannes Sixt <j.sixt@viscovery.net> writes:

> Like this?

Yeah, and in addition to "puts", "write(2)" is also not supported, right?

Show 21 quoted lines

>  color.h |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/color.h b/color.h
> index 7d8da6f..edeaa3e 100644
> --- a/color.h
> +++ b/color.h
> @@ -4,6 +4,11 @@
>  /* "\033[1;38;5;2xx;48;5;2xxm\0" is 23 bytes */
>  #define COLOR_MAXLEN 24
>
> +/*
> + * IMPORTANT: Due to the way these color codes are emulated on Windows,
> + * write them only using printf, fprintf, and fputs. In particular,
> + * do not use puts.
> + */
>  #define GIT_COLOR_NORMAL	""
>  #define GIT_COLOR_RESET		"\033[m"
>  #define GIT_COLOR_BOLD		"\033[1m"
> -- 
> 1.6.6.rc0.43.g50037