Re: [PATCH 6/7] fmt-merge-msg: remove custom string_list implementation

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 30, 2010, 05:18 UTC
Message-ID: <7vzl1qwfno.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1269414964-9518-7-git-send-email-bebarino@gmail.com>

Stephen Boyd <bebarino@gmail.com> writes:

> This command uses a custom version of string list when it could
> just as easily use the string_list API. Convert it to use string_list
> and reduce the code size a bit.

Thanks, although the above is a bit unfair. Back when 00449f9 (Make git-fmt-merge-msg a builtin, 2006-07-03) was written, there was no such thing like string-list (nor path-list, its predecessor).

> Anyone else annoyed that string_list_append() is the only function
> that takes doesn't take the string list as the first argument?

Yes.

Show 6 quoted lines

> On another note, git-compat-util.h:115 says:
>
>   #undef _ALL_SOURCE /* AIX 5.3L defines a struct list with...
>
> which may be unnecessary now that struct list is gone. Need someone
> on AIX 5.3L to test that though.

Yeah, finding testers for less common platforms is always the hardest part.

> Finally, this doesn't free some of the lists since I wanted it to be a
> straight conversion. I'm feeling lazy right now but I'll think about it.

Thanks.