Re: Possible bug with `export-subst' attribute

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 27, 2010, 17:35 UTC
Message-ID: <7vzkxc7rpn.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20100726190448.GA32367@burratino>

Jonathan Nieder <jrnieder@gmail.com> writes:

Show 12 quoted lines

> Junio C Hamano wrote:
>
>> The ones to archive and checkout I understand, but what effect does the
>> one to commit.c::print_summary() have?
>
> Currently commit.c::print_summary() does this:
> ...
> 	if (!log_tree_commit(&rev, commit)) {
> 		...
>
> In other words, it imbues rev with a format including %h and uses that
> to print a commit summary.

Sorry, but I think I understood that part.

But the thing is, we do not seem to show non-abbreviated string there with or without your patch, because inside log_tree_diff_flush() -> show_log() callchain we use opt->diffopt.abbrev to decide what is done for that %h token:

	ctx.abbrev = opt->diffopt.abbrev;

so just like the confusing assignment in builtin/checkout.c, isn't this one in builtin/commit.c also a confusing no-op?

Perhaps I am missing something obvious?